WIP: Support Libusb1 on windows #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
BTW, I'm happy to add you to the org if you'd just like direct push right. :) |
added 2 commits
May 11, 2016 14:20
1) Improve Findlibusb-1.0 : - search for libusb.h path not libusb-1.0/libusb.h (PATH_SUFFIXES helps). - search for usb-1.0 and libusb-1.0 as library names, the later being used on windows. - use find_package_handle_standard_args to ensure variables are found. This results in a change of the camke variables to LIBUSB1_* instead of LIBUSB_1_*. 2) Make Libusb1-0 default on Windows instead of LIBFTD2XX. LibUsb1 can be easily downloaded from sourceforge and wraps the include file, libs for different platforms and generators, static and shared : https://sourceforge.net/projects/libusb/files/libusb-1.0/ For ease of use it would possible to download, archive, and install files from libusb-1.0 easily using CMake ExternalProject_Add() macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libusb-1.0 - #42
Improve Findlibusb-1.0
PATH_SUFFIXEShelps).used on windows.
find_package_handle_standard_args()to ensure variables are found.This results in a change of the cmake variables to
LIBUSB1_* insteadof
LIBUSB_1_*.Make Libusb1-0 default on Windows
Instead of LIBFTD2XX.
LibUsb1 can be easily downloaded from sourceforge and wraps the include file, libs for different platforms and generators, static and shared : https://sourceforge.net/projects/libusb/files/libusb-1.0/
For ease of use it would possible to download, archive, and install files from libusb-1.0 within the project easily using CMake
ExternalProject_Add()macro.