Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix examples JSON #549

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Conversation

SFrijters
Copy link
Contributor

Description

A stay colon is breaking the examples in CTest.

Also, apparently occa JSON parser is rather lenient since string keys/values should be quoted using double quotes, not single quotes. I've changed only the ones in the same CMake file, but there's probably more scattered throughout.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #549 (c24a22f) into main (3e11ab4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   76.35%   76.34%   -0.01%     
==========================================
  Files         262      262              
  Lines       19520    19520              
==========================================
- Hits        14904    14903       -1     
- Misses       4616     4617       +1     
Impacted Files Coverage Δ
src/occa/internal/lang/specialMacros.cpp 59.60% <0.00%> (-0.67%) ⬇️

@kris-rowe kris-rowe merged commit a14fcd4 into libocca:main Dec 20, 2021
@SFrijters SFrijters deleted the fix-examples-json branch June 8, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants