Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Zero size memory quick returns #678

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

noelchalmers
Copy link
Contributor

@noelchalmers noelchalmers commented Apr 22, 2023

Description

Let some memory methods return quickly instead of error when they are zero size allocations.

Addresses #648, but in a different manner than PR #649.

@MalachiTimothyPhillips can you weight in if this would solve your issue?

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #678 (9398b6c) into development (cbdd074) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9398b6c differs from pull request most recent head 459ed52. Consider uploading reports for the commit 459ed52 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #678      +/-   ##
===============================================
- Coverage        76.23%   76.22%   -0.01%     
===============================================
  Files              291      291              
  Lines            18798    18795       -3     
===============================================
- Hits             14330    14326       -4     
- Misses            4468     4469       +1     
Impacted Files Coverage Δ
src/core/memory.cpp 83.33% <100.00%> (-0.12%) ⬇️

... and 2 files with indirect coverage changes

@kris-rowe
Copy link
Member

Since these changes were included in nekRS after this PR was opened, I am going to assume that this solution works for them.

@kris-rowe kris-rowe merged commit a2adec6 into libocca:development Aug 11, 2023
6 checks passed
@kris-rowe kris-rowe linked an issue Aug 24, 2023 that may be closed by this pull request
kris-rowe pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-word allocations do not work with slicing, copyTo, copyFrom
2 participants