cmake: Small fix to prevent empty module path #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a chain of cmake package config projects using find_dependency(), where each would use the same code to temporarily adapt the module path, the path would end up empty in the end, even if it wasn't empty before, because of the unset() call of a not-package-specific variable. Therefore, make the variable name package specific.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 291 291
Lines 18777 18777
=======================================
Hits 14326 14326
Misses 4451 4451 |
kris-rowe
pushed a commit
that referenced
this pull request
Jan 24, 2024
kris-rowe
pushed a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a chain of cmake package config projects using find_dependency(), where each would use the same code to temporarily adapt the module path, the path would end up empty in the end, even if it wasn't empty before, because of the unset() call of a not-package-specific variable. Therefore, make the variable name package specific.