Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qualifiers from lhs of sycl local variable declarations. #702

Merged

Conversation

kris-rowe
Copy link
Member

Details

  • Currently @shared declarations with qualifiers lead to compilation errors since we use auto&
  • Example: @shared long int x[3] is translated to long auto& x = ... instead of auto& x = ...
  • Qualifiers are still included in the template parameter of the RHS call for allocating local memory.

@kris-rowe kris-rowe added bug Use this label when reporting bugs! parser DPC++ labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #702 (ee70acf) into development (1590291) will increase coverage by 0.00%.
Report is 1 commits behind head on development.
The diff coverage is n/a.

❗ Current head ee70acf differs from pull request most recent head cff92da. Consider uploading reports for the commit cff92da to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #702   +/-   ##
============================================
  Coverage        76.24%   76.24%           
============================================
  Files              292      292           
  Lines            18825    18825           
============================================
+ Hits             14353    14354    +1     
+ Misses            4472     4471    -1     
Files Changed Coverage Δ
src/occa/internal/lang/modes/dpcpp.cpp 82.78% <ø> (ø)

... and 1 file with indirect coverage changes

@kris-rowe kris-rowe force-pushed the bugfix/okl-shared-with-qualifiers branch from c61f0b5 to 97e8340 Compare August 21, 2023 18:03
@kris-rowe kris-rowe force-pushed the bugfix/okl-shared-with-qualifiers branch from 97e8340 to cff92da Compare August 21, 2023 18:50
@kris-rowe kris-rowe merged commit 29fc5ed into libocca:development Aug 21, 2023
6 checks passed
@kris-rowe kris-rowe deleted the bugfix/okl-shared-with-qualifiers branch August 21, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label when reporting bugs! DPC++ parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant