Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to define the maximum number of kernel arguments #718

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

deukhyun-cha
Copy link
Contributor

Allow user to define the maximum number of kernel arguments as a CMake parameter and auto-generate the necessary codes if needed. This is to provide flexibility for any larger number of kernel argument required by an application and to optimize the compile time. When the default value predefined is used it compile with generated codes already there without re-generating them.

@deukhyun-cha
Copy link
Contributor Author

deukhyun-cha commented Nov 14, 2023

There is a couple of remarks;

  • Using Makefile requires defining the variable and running the python script manually if needed. Applying the same default value would be useful (updated).
  • Minimum required version of python to run the python script for code generation was obtained with a limited test set (ex. 3.5.1 doesn't work, 3.7.2 works). This could probably be improved.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #718 (d02cc59) into development (ec6e59d) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d02cc59 differs from pull request most recent head 63dbab5. Consider uploading reports for the commit 63dbab5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #718   +/-   ##
============================================
  Coverage        75.26%   75.27%           
============================================
  Files              297      297           
  Lines            19324    19327    +3     
============================================
+ Hits             14544    14548    +4     
+ Misses            4780     4779    -1     

see 2 files with indirect coverage changes

@kris-rowe kris-rowe merged commit 2eae23b into libocca:development Nov 22, 2023
6 checks passed
@deukhyun-cha deukhyun-cha deleted the n-kernel-arg-cmake branch November 27, 2023 22:07
kris-rowe pushed a commit that referenced this pull request Jan 24, 2024
kris-rowe pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants