Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: device::finishAll()` #723

Merged
merged 1 commit into from Nov 30, 2023
Merged

Bugfix: device::finishAll()` #723

merged 1 commit into from Nov 30, 2023

Conversation

kris-rowe
Copy link
Member

Closes #721

@kris-rowe kris-rowe added bug Use this label when reporting bugs! runtime Related to the OCCA runtime API labels Nov 30, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited

Codecov Report

Merging #723 (cea63b7) into development (9e86ae7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #723      +/-   ##
===============================================
- Coverage        75.26%   75.25%   -0.01%     
===============================================
  Files              297      297              
  Lines            19325    19330       +5     
===============================================
+ Hits             14545    14547       +2     
- Misses            4780     4783       +3
Files Coverage Δ
src/occa/internal/core/device.hpp 100.00% <ø> (ø)
src/occa/internal/core/device.cpp 72.22% <0.00%> (-3.15%) ⬇️

... and 1 file with indirect coverage changes

@kris-rowe kris-rowe changed the base branch from main to development November 30, 2023 04:52
@kris-rowe kris-rowe merged commit b0c3227 into libocca:development Nov 30, 2023
7 of 8 checks passed
@kris-rowe kris-rowe deleted the bugfix/device-finish-all branch November 30, 2023 05:14
kris-rowe added a commit that referenced this pull request Jan 24, 2024
@kris-rowe
Correctly sync all streams in device::finishAll(). (#723)
789e9fc
kris-rowe added a commit that referenced this pull request Mar 12, 2024
@kris-rowe
Correctly sync all streams in device::finishAll(). (#723)
c824a2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Use this label when reporting bugs! runtime Related to the OCCA runtime API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling finishAll() from occa::device has no effect.
1 participant
@kris-rowe