Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SYCL subgroup size via kernel property or @simd_length attribute. #726

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

kris-rowe
Copy link
Member

Description

  • Introduces the @simd_length attribute and kernel property
  • For dpcpp mode these can be used to prescribe which subgroup size will be used
  • OpenCL and OpenMP modes could make use of this property in the future

Closes #693

@kris-rowe kris-rowe added feature Use this label to request a new feature! OKL DPC++ labels Dec 8, 2023
@kris-rowe kris-rowe linked an issue Dec 8, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #726 (996bd56) into development (8957558) will decrease coverage by 0.05%.
The diff coverage is 70.42%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #726      +/-   ##
===============================================
- Coverage        75.26%   75.22%   -0.05%     
===============================================
  Files              297      299       +2     
  Lines            19327    19387      +60     
===============================================
+ Hits             14546    14583      +37     
- Misses            4781     4804      +23     
Files Coverage Δ
src/occa/internal/lang/attribute.cpp 69.82% <100.00%> (+0.80%) ⬆️
...a/internal/lang/builtins/attributes/simdLength.hpp 100.00% <100.00%> (ø)
src/occa/internal/lang/modes/dpcpp.hpp 100.00% <ø> (ø)
src/occa/internal/lang/modes/okl.cpp 93.67% <100.00%> (+0.03%) ⬆️
src/occa/internal/lang/modes/withLauncher.cpp 94.24% <100.00%> (+0.03%) ⬆️
...a/internal/lang/builtins/attributes/simdLength.cpp 50.00% <50.00%> (ø)
src/occa/internal/lang/modes/dpcpp.cpp 80.42% <75.00%> (-2.48%) ⬇️

... and 2 files with indirect coverage changes

@kris-rowe kris-rowe marked this pull request as ready for review December 8, 2023 07:31
@kris-rowe kris-rowe merged commit 66ae951 into libocca:development Dec 15, 2023
8 checks passed
@kris-rowe kris-rowe deleted the sycl/sub-group-size branch December 15, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPC++ feature Use this label to request a new feature! OKL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable user to set intel::reqd_sub_group_size through occa::properties
1 participant