Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**BREAKING** Make memory copies data type aware for consistency. #728

Merged
merged 6 commits into from
Dec 15, 2023
Merged

**BREAKING** Make memory copies data type aware for consistency. #728

merged 6 commits into from
Dec 15, 2023

Conversation

kris-rowe
Copy link
Member

Closes #686

@kris-rowe kris-rowe changed the title Make memory copies data type aware for consistency. **BREAKING** Make memory copies data type aware for consistency. Dec 11, 2023
@kris-rowe kris-rowe linked an issue Dec 11, 2023 that may be closed by this pull request
For consistency memory::copyFrom and memory::copyTo should be dtype aware #686
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Merging #728 (1ce394b) into development (8957558) will increase coverage by 0.01%.
Report is 1 commits behind head on development.
The diff coverage is 96.55%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #728      +/-   ##
===============================================
+ Coverage        75.26%   75.27%   +0.01%     
===============================================
  Files              297      297              
  Lines            19327    19336       +9     
===============================================
+ Hits             14546    14556      +10     
+ Misses            4781     4780       -1
Files Coverage Δ
include/occa/core/memory.hpp 100.00% <ø> (ø)
include/occa/functional/typelessArray.hpp 73.49% <100.00%> (ø)
src/core/memory.cpp 84.51% <100.00%> (+1.18%) ⬆️
include/occa/functional/array.hpp 94.15% <88.88%> (+0.56%) ⬆️

@kris-rowe kris-rowe merged commit ce6f23c into libocca:development Dec 15, 2023
8 checks passed
@kris-rowe kris-rowe deleted the feature/memory-dtype-copy branch December 15, 2023 04:04
kris-rowe added a commit that referenced this pull request Jan 24, 2024
@kris-rowe
**BREAKING** Make memory copies data type aware for consistency. (#728)
6084f64
kris-rowe added a commit that referenced this pull request Mar 12, 2024
@kris-rowe
**BREAKING** Make memory copies data type aware for consistency. (#728)
7d9d089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For consistency memory::copyFrom and memory::copyTo should be dtype aware
1 participant
@kris-rowe