Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stlink-flash target not supported? #99

Closed
tdicola opened this issue Aug 4, 2015 · 3 comments
Closed

stlink-flash target not supported? #99

tdicola opened this issue Aug 4, 2015 · 3 comments

Comments

@tdicola
Copy link

tdicola commented Aug 4, 2015

I was looking at reusing the makefiles from the examples here and noticed the stlink-flash target doesn't seem to be fully setup. In Makefile.rules there's a definition for the %.stlink-flash target that runs st-flash here: https://github.com/libopencm3/libopencm3-examples/blob/master/examples/Makefile.rules#L197-L199 However I don't see anything in the file that depends on a $(BINARY).stlink-flash target which would trigger that flashing rule.

I think there should be something like stlink-flash: $(BINARY).stlink-flash added to this block that generates these flashing targets: https://github.com/libopencm3/libopencm3-examples/blob/master/examples/Makefile.rules#L134-L135 That way you could run 'make stlink-flash' in an example folder and it would use st-flash to upload the binary. Just wanted to check am I missing something else that adds that rule, or would this be a useful pull to send back to this repo?

Thanks for providing the great library & examples BTW!

@karlp
Copy link
Member

karlp commented Aug 11, 2015

I'm actually much more inclined to just remove all of the flash helping snippets from the makefiles. They have various attempts to support both texane/stlink and openocd and black magic probe, and they try and support various debug hardware for openocd as well. I plan on just updating the readme with a few links on how to flash, but it's kinda out of scope, and always relied on out of tree software to be installed correctly.

@karlp
Copy link
Member

karlp commented Aug 11, 2015

Closing as a duplicate of #34

@karlp karlp closed this as completed Aug 11, 2015
@tdicola
Copy link
Author

tdicola commented Aug 13, 2015

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants