Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2c_common_v2: ADDRIE bitmask is named I2C_CR1_DDRIE #925

Closed
tuankiet65 opened this issue May 30, 2018 · 1 comment
Closed

i2c_common_v2: ADDRIE bitmask is named I2C_CR1_DDRIE #925

tuankiet65 opened this issue May 30, 2018 · 1 comment

Comments

@tuankiet65
Copy link

tuankiet65 commented May 30, 2018 •
edited

The bitmask should be named I2C_CR1_ADDRIE but is instead named I2C_CR1_DDRIE (spelling error?). I'm afraid to open a pull request though because this could be a breaking change so I'm looking for opinions regarding this issue.

libopencm3/include/libopencm3/stm32/common/i2c_common_v2.h

Line 157 in ed90df8

#define I2C_CR1_DDRIE (1 << 3)

karlp added a commit that referenced this issue Jun 7, 2018
@karlp
stm32: i2c-v2: Fix typo in CR1_ADDRIE
2352d5d 
Reported in: #925
@karlp
Copy link
Member

karlp commented Jun 7, 2018

Fixed in 2352d5d thanks!

@karlp karlp closed this as completed Jun 7, 2018
abhisit pushed a commit to abhisit/libopencm3 that referenced this issue Aug 15, 2018
@karlp @abhisit
stm32: i2c-v2: Fix typo in CR1_ADDRIE
2825c53 
Reported in: libopencm3#925
BOJIT pushed a commit to BOJIT/PlatformIO-libopencm3 that referenced this issue Jan 30, 2021
@karlp @BOJIT
stm32: i2c-v2: Fix typo in CR1_ADDRIE
852ee65 
Reported in: libopencm3#925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlp @tuankiet65