Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32: When setting baudrate of a USART, first get the clock frequency for that USART. #1456

Closed
wants to merge 2 commits into from
Closed

stm32: When setting baudrate of a USART, first get the clock frequency for that USART. #1456

wants to merge 2 commits into from

Conversation

harryg-oss
Copy link
Contributor

Hi,
A quick commit to get the clock frequency for the USART before calculating the value for the desired baudrate.
Thanks.

@slorquet slorquet mentioned this pull request Jan 12, 2023
Open
@slorquet
Copy link
Contributor

Hi,
This pull request has the correct fix. Can you push it or tell me what prevents you from doing so?
#1452

Thanks

slorquet
slorquet approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@slorquet slorquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@karlp
Copy link
Member

karlp commented Feb 3, 2023

This has merged in 4d7a2ca. It required e643f66 first, or g4 would never have linked properly. Thanks for pushing this forwards!

@karlp karlp closed this Feb 3, 2023
@slorquet
Copy link
Contributor

slorquet commented Feb 3, 2023 •
edited

Thank you for merging! The quality of your interventions is very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlp karlp karlp left review comments

@slorquet slorquet slorquet approved these changes

Assignees
No one assigned
Labels
needs info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harryg-oss @slorquet @karlp