STM32F3: flash programming operations added #627
Conversation
| Clears program error, end of operation, busy flags. | ||
| */ | ||
| Program error, end of operation, write protect error, busy. | ||
| */ |
There was a problem hiding this comment.
I undertand adding write protect, but why remove the fairly important "clears" verb?
|
Apart from the general style comments above, please note that this is all common code with f0. Please combine the f0 code with this in some way, rather than duplicating it further. |
|
Before duplicating I started to combine it with F0 Code. But it lead to rework the whole flash module over all families. In my opinion that should not be part of this pull request. If you gonna accept this pull request as it is, I could fix the style comments you mentioned. Otherwise please reject and create an issue. |
|
Ok well if I merge this, it just makes the work of finally merging the flash code even harder. So I'm not super motivated to do that. It's very easy to add code that "improves things for this one platform" but that doesn't help anyone next year. |
|
It should be a good beginning ot just make a common/flash_v3.c or something (v1 being f1, v2 something else) and use the _v3 file in f0 and f3. The current naming of the "common" files makes it very hard to follow, I agree, but you shouldn't have to overhaul the entire flash driver just to start work o n f3 and f0 combining |
This improves on PR libopencm3#627
Originally filed as libopencm3#627
Originally filed as libopencm3#627
Originally filed as libopencm3#627
|
I think I've covered most/all of this via the commits merged just above. |
Originally filed as libopencm3#627
No description provided.