minor USB improvements #924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the pointer table to be in Flash, by using
"static const char * const strings[] = { ... };"
Extend usbd_init() docs & describe NAK/read_packet pitfalls.
usb_disconnect() is board/platform specific for chips that don't have built-in handling for this. Allow the application to provide its own version of usb_disconnect() to handle this.
karlp
reviewed
May 26, 2018
| * @li @link stm32f207_usb_driver @endlink | ||
| * @li @link st_usbfs_v2_usb_driver @endlink | ||
| * @li @link efm32lg_usb_driver @endlink | ||
| * @li @link efm32hg_usb_driver @endlink |
There was a problem hiding this comment.
oooh nice doxygen. is there anyway to j ust link to a type name? we can then make the drivers be members of that instead. ie, the efm32 driver is already refactored in my local tree.
There was a problem hiding this comment.
I have no idea, I wrote this with googling and the Doxygen manual open on the side ;)
|
Can you not just put your desired disconnect function into the driver struct? |
|
Modifying the driver struct is kindof impossible:
I've thought about it quite a bit and really think a weak |
|
I've pulled these locally, they all look good. |
karlp
pushed a commit
to karlp/libopencm3
that referenced
this pull request
Aug 25, 2018
This allows the pointer table to be in Flash, by using
"static const char * const strings[] = { ... };"
See libopencm3#924
karlp
pushed a commit
to karlp/libopencm3
that referenced
this pull request
Aug 25, 2018
Extend usbd_init() docs & describe NAK/read_packet pitfalls. See libopencm3#924
karlp
pushed a commit
to karlp/libopencm3
that referenced
this pull request
Aug 25, 2018
usb_disconnect() is board/platform specific for chips that don't have built-in handling for this. Allow the application to provide its own version of usb_disconnect() to handle this. See libopencm3#924
karlp
pushed a commit
that referenced
this pull request
Aug 27, 2018
This allows the pointer table to be in Flash, by using
"static const char * const strings[] = { ... };"
See #924
karlp
pushed a commit
that referenced
this pull request
Aug 27, 2018
usb_disconnect() is board/platform specific for chips that don't have built-in handling for this. Allow the application to provide its own version of usb_disconnect() to handle this. See #924
karlp
pushed a commit
to karlp/libopencm3
that referenced
this pull request
Aug 27, 2018
Extend usbd_init() docs & describe NAK/read_packet pitfalls. See libopencm3#924 REVIEW: check whether the docs are correct, and make sure that TI driver is added
karlp
pushed a commit
to karlp/libopencm3
that referenced
this pull request
Aug 28, 2018
Extend usbd_init() docs & describe NAK/read_packet pitfalls. See libopencm3#924 REVIEW: check whether the docs are correct, and make sure that TI driver is added
grevaillot
pushed a commit
to grevaillot/libopencm3
that referenced
this pull request
Jan 11, 2019
This allows the pointer table to be in Flash, by using
"static const char * const strings[] = { ... };"
See libopencm3#924
grevaillot
pushed a commit
to grevaillot/libopencm3
that referenced
this pull request
Jan 11, 2019
usb_disconnect() is board/platform specific for chips that don't have built-in handling for this. Allow the application to provide its own version of usb_disconnect() to handle this. See libopencm3#924
BOJIT
pushed a commit
to BOJIT/PlatformIO-libopencm3
that referenced
this pull request
Jan 30, 2021
This allows the pointer table to be in Flash, by using
"static const char * const strings[] = { ... };"
See libopencm3#924
BOJIT
pushed a commit
to BOJIT/PlatformIO-libopencm3
that referenced
this pull request
Jan 30, 2021
usb_disconnect() is board/platform specific for chips that don't have built-in handling for this. Allow the application to provide its own version of usb_disconnect() to handle this. See libopencm3#924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see individual commits)