Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(interop-tests): update job names of multidimensional interop tests #158

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Jun 14, 2023

Summary

With libp2p/rust-libp2p#4015 the multidimensional interoperability tests have changed.

Why do you need this?

This is needed for libp2p/rust-libp2p#4015.

What else do we need to know?

I think this must be merged only after libp2p/rust-libp2p#4015 gets merged. @thomaseizinger is this correct?

DRI: @thomaseizinger

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@oblique oblique requested review from a team as code owners June 14, 2023 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (11 unchanged attributes hidden)

      ~ required_status_checks {
          ~ contexts = [
              + "Run all WASM tests",
              - "Run multidimensional interoperability tests",
              + "Run multidimensional interoperability tests (chromium)",
              + "Run multidimensional interoperability tests (native)",
                # (50 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@oblique oblique changed the title chrome(interop-tests): update job names of multidimensional interop tests chore(interop-tests): update job names of multidimensional interop tests Jun 14, 2023
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jun 14, 2023

I think this must be merged only after libp2p/rust-libp2p#4015 gets merged. @thomaseizinger is this correct?

Almost, we have to merge it just before. Merging this will PR will update the rules around required checks. Because libp2p/rust-libp2p#4015 changes some CI jobs, we can only merge it once the rules are updated but we need to keep the window in between short because we can't merge any other PRs in the meantime.

Thanks for opening this so pro-actively <3

@mxinden mxinden merged commit b90a264 into libp2p:master Jun 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants