Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Offload peers supporting AutoNAT to peerstore #9

Closed
raulk opened this issue Feb 11, 2019 · 2 comments
Closed

Offload peers supporting AutoNAT to peerstore #9

raulk opened this issue Feb 11, 2019 · 2 comments

Comments

@raulk
Copy link
Member

raulk commented Feb 11, 2019

Currently we store every peer we've ever seen that supports AutoNAT the peers map. This list only grows, thus leading to memory leak. We should only store connected AutoNAT peers in memory, and offload the disconnected ones to the peerstore. This requires changes in the peerstore: https://github.com/libp2p/go-libp2p-peerstore/issues/55.

@jacobheun jacobheun added this to the Working Kademlia milestone Jan 24, 2020
@aarshkshah1992
Copy link
Collaborator

aarshkshah1992 commented Feb 26, 2020

An alternative solution could be #40 (comment).

willscott added a commit that referenced this issue Mar 11, 2020
* Single goroutine managing autonat-relevent events.
* Watching incoming connections and local interface changes as signals.
* Emit a single 'rechabilitychanged' persistent event

fix #40 
fix #36 
fix #35
fix #34 
fix #11
obsolete #28
obsolete #9 

Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
@willscott
Copy link
Contributor

autonat no longer maintains its own cache separate from peerstore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants