This repository has been archived by the owner on May 11, 2022. It is now read-only.
Add option to force nat into a specified reachability state #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Mar 18, 2020
svc.go
Outdated
| @@ -46,7 +46,7 @@ func newAutoNATService(ctx context.Context, c *config) (*autoNATService, error) | |||
| reqs: make(map[peer.ID]int), | |||
| } | |||
|
|
|||
| if c.forceServer { | |||
| if c.forceServer || c.forceReachability { | |||
There was a problem hiding this comment.
We should probably get rid of the forceServer option, right?
There was a problem hiding this comment.
Also, what if we're forcing "unreachable"? Will we not start in that case?
There was a problem hiding this comment.
removed. When unreachable, the service object won't be created in autonat.New
willscott
force-pushed
the
feat/override
branch
from
4416bf8
to
849d407
Compare
Stebalien
reviewed
Mar 19, 2020
Stebalien
approved these changes
Mar 20, 2020
| reachability: conf.reachability, | ||
| service: service, | ||
| }, nil | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more common way we want to expose "don't run autonat" at the libp2p level is probably "force this node to believe it (is/isn't) natted" rather than "don't run the service or report any reachability. The later better decouples the nat subsystem from other systems like DHT or relaying.
ref: libp2p/go-libp2p#845