Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

implement Stringer for network.{Direction,Connectedness,Reachability}. #150

Merged
merged 2 commits into from May 14, 2020
Merged

implement Stringer for network.{Direction,Connectedness,Reachability}. #150

merged 2 commits into from May 14, 2020

Conversation

raulk
Copy link
Member

@raulk raulk commented May 13, 2020

Pretty non-controversial.

@raulk raulk requested a review from aarshkshah1992 May 13, 2020 12:46
Stebalien
Stebalien approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to not panic if we get an unknown reachability type (I'm concerned users may cast to these constants to/from the network).

@raulk
Copy link
Member Author

raulk commented May 14, 2020

@Stebalien makes sense, I'll rejig this. I also felt kinda uncomfortable panicking instead of returning something like: "(unrecognized)"

@raulk raulk merged commit 9d35da1 into master May 14, 2020
@raulk raulk deleted the feat/stringer branch May 14, 2020 16:16
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raulk @Stebalien @aarshkshah1992