QUIC support #34
Merged
QUIC support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
raulk
approved these changes
Nov 29, 2018
|
@vyzo I assume you tested the packaging. There was an issue reported here: libp2p/go-libp2p-quic-transport#33 |
|
I guess it doesn't matter that much because we expect people to build the daemon with make. |
|
yeah, we build after gx-go rw so that issue doesn't affect us. |
|
ok, this not working yet. |
|
Yeah, jumped the gun too soon. Looks like a generalised test failure. |
|
updated the gx dependencies, but now when I start the daemon with -quic the other transports disappear. |
|
ok, it seems that I have to explicitly specify listen addresses when I explicitly specify transports. |
|
alright, now it should be good. perhaps we should have a quicOnly mode that disables the other listen addrs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the QUIC transport, enabled with the
-quicflag.Closes #33.