Port prometheus to opencensus wrapper #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Why not just expose all metrics, all the time? They're suitably name-spaced that choosing which ones to use can be done further down the line by tools better suited for it. |
|
maybe i misunderstood but doesn’t registering them cause them to impact performance? idea was to allow users to selectively not register metrics. definitely down to instrument everything if we don’t mind! |
vyzo
approved these changes
Mar 21, 2019
|
Note CI is failing again. |
6 tasks
anacrolix
reviewed
Apr 12, 2019
p2pd/metrics.go
Outdated
| } | ||
| view.RegisterExporter(pe) | ||
|
|
||
| if err = psmetrics.Register(); err != nil { |
There was a problem hiding this comment.
Per comments on the other PR, this would look like this: https://github.com/anacrolix/go-libp2p-dht-tool/blob/feat/oc-metrics/main.go#L377. What do you think?
anacrolix
approved these changes
Apr 16, 2019
| mux := http.NewServeMux() | ||
| mux.Handle("/metrics", pe) | ||
| if err := http.ListenAndServe(*metricsAddr, mux); err != nil { | ||
| log.Printf("setting up metrics endpoint (%s): %s", *metricsAddr, err) |
There was a problem hiding this comment.
Try setting up metrics endpoint %q: %v :)
added 5 commits
April 26, 2019 16:36
This change also introduces a very naive metricsModules map that collects, by name, all of the modules present in the daemon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also introduces a very naive metricsModules map that
collects, by name, all of the modules present in the daemon.
Sorry for the confusion here, @vyzo. @anacrolix and @lanzafame made a compelling argument to switch to OpenCensus and I decided to make the jump before it's too late. Still exposing a prometheus-friendly collection endpoint.