Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce background goroutines #340

Merged
merged 2 commits into from May 24, 2019
Merged

reduce background goroutines #340

merged 2 commits into from May 24, 2019

Conversation

Stebalien
Copy link
Member

  • Kill idle inbound streams after 10 minutes. We should also do outbound streams
    but we can handle that separately.
  • Reduce the number of goroutines used by inbound streams by 1 by not bothering
    with the "context reader".

@Stebalien
drop the go-context dependency
5bf9cf5 
This was causing us to build up a bunch of background goroutines. Technically,
we should be resetting all these streams when the DHT stops. However, we don't
actually unregister stream handlers from the host so, really, nothing will
actually stop till the host stops. When it does, it'll kill all the streams
anyways.
@Stebalien
kill idle streams after 10 minutes
b55fad1
@Stebalien Stebalien merged commit 978eca5 into master May 24, 2019
@Stebalien Stebalien deleted the feat/fewer-goroutines branch May 24, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stebalien @vyzo