feat: allow disabling value and provider storage/messages #400
Conversation
There was a problem hiding this comment.
That's a little funky.
One question wrt correctness is that the local option affects the propagation of messages to the network.
Ie if we disable values/providers, then GetValue and FindProviders will short-circuit and not send any messages to the network.
However, we might have peers that are able to answer these queries because they have these options enabled.
Is this intended?
| @@ -110,6 +114,10 @@ type RecvdVal struct { | |||
|
|
|||
| // GetValue searches for the value corresponding to given Key. | |||
| func (dht *IpfsDHT) GetValue(ctx context.Context, key string, opts ...routing.Option) (_ []byte, err error) { | |||
| if !dht.enableValues { | |||
There was a problem hiding this comment.
is this correct behaviour? We might know a peer that supports GetValue and so on.
| @@ -477,6 +495,9 @@ func (dht *IpfsDHT) makeProvRecord(skey cid.Cid) (*pb.Message, error) { | |||
|
|
|||
| // FindProviders searches until the context expires. | |||
| func (dht *IpfsDHT) FindProviders(ctx context.Context, c cid.Cid) ([]peer.AddrInfo, error) { | |||
| if !dht.enableProviders { | |||
Yes. This feature is intended to be used in private/forked DHTs with custom protocol names (e.g., the Filecoin DHT). |
@Stebalien Could this get documented in the code? Maybe on the struct values: |
|
@lanzafame I'm documenting the options. |
Stebalien
force-pushed
the
feat/disable-providers
branch
from
d43ce3c
to
c2b72b2
Compare
|
(eh, I did it in both places) |
None. It was only ever used for validating IPNS records and:
They'll continue to work:
|
fixes #274