Cypress Disjoint Query & Query Termination code cleanup #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Mar 11, 2020
| isLess := ph.compare(h[i].Peer, h[j].Peer) | ||
|
|
||
| // because the "compare" function returns true if peer1 is less than peer2, | ||
| // we need to reverse it's result if the Heap is a maxHeap. |
There was a problem hiding this comment.
Suggested change
| // we need to reverse it's result if the Heap is a maxHeap. | |
| // we need to reverse the result if the Heap is a maxHeap. |
aarshkshah1992
changed the title
willscott
reviewed
Mar 12, 2020
aschmahmann
requested changes
Mar 13, 2020
Stebalien
pushed a commit
that referenced
this pull request
Mar 13, 2020
* kpeerset refactoring * query code cleanup
Stebalien
pushed a commit
that referenced
this pull request
Apr 3, 2020
* kpeerset refactoring * query code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the code, add docs & tests for the new query code for cypress.