Update default concurrency parameter #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 23, 2020
|
Can you comment on the reasoning behind this change ? This does not match what I found in my experiments (the lower the concurrency the better). |
|
This is the default concurrency we ship go-ipfs with. We found that it massively reduced the time it takes to find content. Before this change, the new DHT was often slower at finding content than the old DHT as the old DHT quickly ramped up parallelism to ~20. Now, it's ~2-3x faster, even with all the old nodes clogging up the network. The hope is that something like #546 will allow us to bring the parallelism back down but this PR brings this package in-line with how we're using it on the network. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.