Double the usefulness interval for peers in the Routing Table #651
Conversation
|
The |
|
@Stebalien We now pass |
aarshkshah1992
changed the title
There was a problem hiding this comment.
This PR is fine and should only make things better/stay the same. However, I would've liked for us to run some tests to demonstrate that increasing the usefulness threshold actually helps us.
If we're going to be running testground tests on this in the near future to examine this parameter then we should probably make the usefulness threshold be configurable (see comment)
| // use twice the theoritical usefulness threhold to keep older peers around longer | ||
| rt, err := makeRoutingTable(dht, cfg, 2*maxLastSuccessfulOutboundThreshold) |
There was a problem hiding this comment.
@aarshkshah1992 what do you think about having the usefulness here be an option so that we can play around with it in testground?
Perhaps something like an option that takes func(refreshThreshold time.Duration) time.Duration?
There was a problem hiding this comment.
@Stebalien @aschmahmann