Hardening Improvements: RT diversity and decreased RT churn #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c985184.
* reduce churn
This is a BREAKING CHANGE for the dual DHT but it should be a relatively minor one. Co-authored-by: Petar Maymounkov <petarm@gmail.com>
aschmahmann
force-pushed
the
feat/merge-dht-hardening-0.7
branch
from
0137dd6
to
57a49f1
Compare
testing: add test-specific option to force processing of Host address changes even when AutoRefresh is disabled
aschmahmann
force-pushed
the
feat/merge-dht-hardening-0.7
branch
from
0c47865
to
5729f0a
Compare
petar
approved these changes
Aug 17, 2020
| } | ||
| } | ||
|
|
||
| return false, -1, peersToQuery |
There was a problem hiding this comment.
const LookupNotCompleted = -1
There was a problem hiding this comment.
eh, we never actually use this -1 anywhere (or even comparisons like > 0) so it's not obvious where to declare LookupNotCompleted. If we ever start using it we can always introduce the const then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.