Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some libp2p dependencies #798

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

marten-seemann
Copy link
Contributor

Specifically those that were pulling in (the deprecated) go-libp2p-core as an indirect dependency, which would prevent building this repo with the upcoming go-libp2p v0.24.0 release.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Kubo is already on o-libp2p-routing-helpers v0.4.1 etc.

❓ there are random ci errors – are these false-positives due to test coverage, or something more serious?
(i see similar problem in master)

@marten-seemann
Copy link
Contributor Author

❓ there are random ci errors – are these false-positives due to test coverage, or something more serious?
(i see similar problem in master)

Tests in this repo seem very flaky.

@marten-seemann marten-seemann merged commit 52df476 into master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants