chore: Update to go libp2p v0.25 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2023
MarcoPolo
changed the title
Jorropo
requested changes
Feb 9, 2023
There was a problem hiding this comment.
I think you should rebase on @marten-seemann v0.24.2 and my v0.25.0 work here.
You can rebase on #814's branch.
MarcoPolo
force-pushed
the
update-go-libp2p-v025
branch
from
6c2045a
to
4eb06f3
Compare
Jorropo
approved these changes
Feb 10, 2023
| @@ -11,6 +11,7 @@ import ( | |||
| "github.com/libp2p/go-libp2p/core/protocol" | |||
|
|
|||
| logging "github.com/ipfs/go-log" | |||
| //lint:ignore SA1019 TODO migrate away from gogo pb | |||
There was a problem hiding this comment.
I spent 10 minutes and failed.
There was a problem hiding this comment.
What’s the problem? I did this for libp2p and it should be quite straightforward. Maybe I can help?
There was a problem hiding this comment.
There's a makefile that doesn't work. It needs you to fetch certain dependencies before running make. That script needs to get updated (or removed in favor of gogenerate). Bonus points for having CI check the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.