Cache the XOR DHT Id for a peerID #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 2, 2020
| // PeerInfo holds all related information for a peer in the K-Bucket. | ||
| type PeerInfo struct { | ||
| // peerInfo holds all related information for a peer in the K-Bucket. | ||
| type peerInfo struct { | ||
| Id peer.ID |
There was a problem hiding this comment.
nit: no need to export this if we're unexporting the struct.
aarshkshah1992
changed the base branch from
feat/new-management-policy
to
master
aarshkshah1992
force-pushed
the
feat/cache-converted-peerId
branch
from
bf4deb1
to
b252c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien @aschmahmann
For libp2p/go-libp2p#812 AND #64.
Saves us from having to do repeated SHA's.