Add LastUsefulAt and LastSuccessfulQueryAt for each peer #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Apr 9, 2020
Stebalien
approved these changes
Apr 9, 2020
| @@ -129,7 +128,8 @@ func (rt *RoutingTable) addPeer(p peer.ID, queryPeer bool) (bool, error) { | |||
|
|
|||
| // We have enough space in the bucket (whether spawned or grouped). | |||
| if bucket.len() < rt.bucketsize { | |||
| bucket.pushFront(&PeerInfo{p, lastSuccessfulOutboundQuery, ConvertPeerID(p)}) | |||
| bucket.pushFront(&PeerInfo{Id: p, LastUsefulAt: lastUsefulAt, LastSuccessfulOutboundQueryAt: time.Now(), | |||
There was a problem hiding this comment.
Technically LastSuccessfullOutboundQueryAt might be wrong (could be an inbound query)... but it's probably fine.
| defer rt.tabLock.Unlock() | ||
|
|
||
| bucketID := rt.bucketIdForPeer(p) | ||
| bucket := rt.buckets[bucketID] |
There was a problem hiding this comment.
Can we add a helper function for this?
There was a problem hiding this comment.
@Stebalien Good point. Will make sure I do in the next RT PR I create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LastUsefulAthelps evict peers that aren't being useful.LastSuccessfulQueryAtdecides which peers we ping periodically to check liveliness.