This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Memory usage #22
Merged
Memory usage #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! We actually fixed this a different way by not advertising and storing a bunch of ephemeral addresses permanently (oops) but I don't see any reason not to accept this change as well. |
Stebalien
suggested changes
Jan 17, 2018
addr_manager.go
Outdated
| delete(maddrs, s) | ||
| } | ||
| if len(maddrs) == 0 { | ||
| mgr.addrs[p] = cleaned |
There was a problem hiding this comment.
This line probably shouldn't be here.
addr_manager.go
Outdated
| if !found { | ||
| amap = make(addrSet) | ||
| mgr.addrs[p] = amap | ||
| amap := make(map[string]expiringAddr) |
addr_manager.go
Outdated
| if !found { | ||
| amap = make(addrSet) | ||
| mgr.addrs[p] = amap | ||
| amap := make(map[string]expiringAddr) |
Stebalien
approved these changes
Jan 17, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15 by replacing
map[string]expiringAddrwith[]expiringAddr, and changes the name of the typeaddrSettoaddrSlice, since the latter term would now be a more accurate description.When I profile it on my machine, on an idle ipfs, this reduces the memory usage of
AddAddrsfrom ~45% of the total to ~15%.