Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Allocations #177

Open
Stebalien opened this issue Apr 25, 2019 · 0 comments
Open

Reduce Allocations #177

Stebalien opened this issue Apr 25, 2019 · 0 comments
Assignees
@vyzo
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

We've noticed issues in bitswap where allocating small internal "request" objects (e.g., addValReq) can get a bit out of hand. We should try to send these requests by-value when possible.
@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Mar 25, 2020
@vyzo vyzo added kind/enhancement A net-new feature or improvement to an existing feature and removed kind/bug A bug in existing code (including security flaws) labels Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyzo vyzo

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyzo @Stebalien @daviddias