Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragmentation for the hello packet #354

Closed
wants to merge 1 commit into from

Conversation

requilence
Copy link

@requilence requilence commented Jun 18, 2020

We have the node with a lot of pubsub subscriptions and observing this problem:

  • The node sends helloPacket to all new peers
  • This packet exceeds the maximum buffer size on clients
  • Connection resets
  • Repeats from the beginning

As a result, pubsub generates 20Mbit outbound 馃槵

This PR uses fragmentRPC introduced in #320 to split the helloPacket payload

@jacobheun
Copy link

@requilence can you look into the failing tests?

@vyzo can you give a quick review of this

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is some complexity with the subscription retransmissions; let me think about this a bit.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the correct way to implement this is to retry all failed transmissions (perhaps the queue got full because there were too many of them), until the hello packet is completely sent (with all fragmented messages) or an error occurs at which point the stream has to be aborted.

@BigLep BigLep added this to In Review in Maintenance Priorities - Go via automation Mar 29, 2021
@BigLep
Copy link

BigLep commented Mar 29, 2021

@vyzo : will close and link to the appropriate issue.

@BigLep
Copy link

BigLep commented Apr 5, 2021

@vyzo : did you create the appropriate issue so we can close this?

@vyzo
Copy link
Collaborator

vyzo commented Apr 6, 2021

@BigLep We already have #402.

@BigLep BigLep linked an issue Apr 6, 2021 that may be closed by this pull request
2 tasks
@BigLep BigLep closed this Apr 6, 2021
Maintenance Priorities - Go automation moved this from In Review to Done Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Handling large number of topic subscriptions
4 participants