Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return protocol ID that is not supported in error message. #1988

Closed
renaynay opened this issue Jan 10, 2023 · 2 comments
Closed

Return protocol ID that is not supported in error message. #1988

renaynay opened this issue Jan 10, 2023 · 2 comments

Comments

@renaynay
Copy link

It would be convenient if the protocol ID that is not supported by the remote peer is returned as well in the error message.

Current:

protocol not supported

Desired:

protocol not supported: <protocol_ID>

@p-shahi p-shahi mentioned this issue Jan 10, 2023
35 tasks
@marten-seemann
Copy link
Contributor

Not opposed to it, but is this particularly useful? You know which protocol(s) you were trying to negotiate when you receive this error.

If we wanted to add the protocol IDs, we'd run into #1886 again.

This is a go-multistream issue, not a go-libp2p issue by the way. Moving it there.

@p-shahi
Copy link
Member

p-shahi commented Jan 10, 2023

moved to multiformats/go-multistream#94 closing this

@p-shahi p-shahi closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants