Disabled using gorilla/websocket version 1.5.1 #2762
Comments
|
Thanks for the context. It seems like they are reverting the problematic commit, and will reintroduce it in parts with fixes. It seems fine to revert and wait for the changes to be reintroduced. |
3 tasks
MarcoPolo
added a commit
that referenced
this issue
Jul 3, 2024
This change has some history. Originally there was v1.5.0, then the project stalled and eventually the repo got archived. Some new maintainers stepped up and released v1.5.1. That version had some controversial changes including excessive logging (see gorilla/websocket#880). This caused us to downgrade this dep back to v1.5.0 (see #2762). The change was short lived as I bumped this dep back up to v1.5.1 without remembering this context. Since then the maintainers of gorilla/websocket have released a new version v1.5.3 that brings the project back to the state of when it got archived (minus a README edit). Bumping to this version should solve our issues with v1.5.1 without having to downgrade back down to v1.5.0.
MarcoPolo
added a commit
that referenced
this issue
Jul 4, 2024
This change has some history. Originally there was v1.5.0, then the project stalled and eventually the repo got archived. Some new maintainers stepped up and released v1.5.1. That version had some controversial changes including excessive logging (see gorilla/websocket#880). This caused us to downgrade this dep back to v1.5.0 (see #2762). The change was short lived as I bumped this dep back up to v1.5.1 without remembering this context. Since then the maintainers of gorilla/websocket have released a new version v1.5.3 that brings the project back to the state of when it got archived (minus a README edit). Bumping to this version should solve our issues with v1.5.1 without having to downgrade back down to v1.5.0.
sukunrt
pushed a commit
that referenced
this issue
Jul 4, 2024
This change has some history. Originally there was v1.5.0, then the project stalled and eventually the repo got archived. Some new maintainers stepped up and released v1.5.1. That version had some controversial changes including excessive logging (see gorilla/websocket#880). This caused us to downgrade this dep back to v1.5.0 (see #2762). The change was short lived as I bumped this dep back up to v1.5.1 without remembering this context. Since then the maintainers of gorilla/websocket have released a new version v1.5.3 that brings the project back to the state of when it got archived (minus a README edit). Bumping to this version should solve our issues with v1.5.1 without having to downgrade back down to v1.5.0.
MarcoPolo
added a commit
that referenced
this issue
Jul 4, 2024
* pstoremanager: fix connectedness check * Close quic conns when wrapping conn fails * Add a transport level test to ensure we close conns after rejecting them by the rcmgr * PR Comments * chore: Bump fx to v1.22.1 (#2857) * chore: Bump gorilla/websocket to 1.5.3 This change has some history. Originally there was v1.5.0, then the project stalled and eventually the repo got archived. Some new maintainers stepped up and released v1.5.1. That version had some controversial changes including excessive logging (see gorilla/websocket#880). This caused us to downgrade this dep back to v1.5.0 (see #2762). The change was short lived as I bumped this dep back up to v1.5.1 without remembering this context. Since then the maintainers of gorilla/websocket have released a new version v1.5.3 that brings the project back to the state of when it got archived (minus a README edit). Bumping to this version should solve our issues with v1.5.1 without having to downgrade back down to v1.5.0. * peerstore: don't intern protocols (#2860) * peerstore: don't intern protocols * peerstore: reduce default protocol limit to 128 * Remove unused mutex --------- Co-authored-by: Marco Munizaga <git@marcopolo.io> * webtransport: close underlying h3 connection (#2862) * release v0.35.2 --------- Co-authored-by: sukun <sukunrt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gorilla/websocket 1.5.1 is a problematic version.
There will be many logs about websocket, and they seem to have introduced some problematic capabilities in this version. The specific information can be viewed at: gorilla/websocket#880
When I use the new version of libp2p, many websocket logs similar to this are output on the terminal:
2024/04/10 20:15:47 websocket: failed to close network connection: close tcp 192.168.1.1:36880->147.75.87.27:443: use of closed network connectionThe text was updated successfully, but these errors were encountered: