Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled using gorilla/websocket version 1.5.1 #2762

Closed
wlynxg opened this issue Apr 10, 2024 · 1 comment · Fixed by #2763
Closed

Disabled using gorilla/websocket version 1.5.1 #2762

wlynxg opened this issue Apr 10, 2024 · 1 comment · Fixed by #2763

Comments

@wlynxg
Copy link
Contributor

wlynxg commented Apr 10, 2024

gorilla/websocket 1.5.1 is a problematic version.
There will be many logs about websocket, and they seem to have introduced some problematic capabilities in this version. The specific information can be viewed at: gorilla/websocket#880

When I use the new version of libp2p, many websocket logs similar to this are output on the terminal:

2024/04/10 20:15:47 websocket: failed to close network connection: close tcp 192.168.1.1:36880->147.75.87.27:443: use of closed network connection
@MarcoPolo
Copy link
Contributor

Thanks for the context. It seems like they are reverting the problematic commit, and will reintroduce it in parts with fixes. It seems fine to revert and wait for the changes to be reintroduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants