update deps due to license #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @aarshkshah1992 |
|
Fixed in #1141. |
|
Ah, wait, you were using a forked branch? That just needs to be rebased. |
|
But you also really shouldn't be using that in a deployed project. That branch will disappear. |
|
Well, no reason not to merge this. It could cause some conflicts, but not likely. |
|
I found that other package like github.com/libp2p/go-yamux v0.5.1 exist the same problem |
|
thanks, @Stebalien I plan to edit the go.mod file in my forked branch, and import the edited branch in our project. when the feature branch about hole punch merged into master, I will re-import the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aarshkshah1992 Hello, we use libp2p in our open source project https://github.com/kubeedge/edgemesh, but go-libp2p-noise v0.1.1 lack of license, so I update this deps to v0.2.0