limit ping duration to 30s

[vyzo]

so that ping streams cannot be squatted

[marten-seemann]

Are we ok with the stream resets this is causing? If so, should we at least fix the logging on our side?

[vyzo]

What else can we do? We cant let the other side ping ad infinum and squat the resources.

What do you recommend doing about logging?

[marten-seemann]

What else can we do? We cant let the other side ping ad infinum and squat the resources.

True. There are multiple options:

1. We could limit the client side to the same value though, so that a well-behaved client would not run into that error. That however would require making this duration a protocol constant.
2. Instead of resetting the stream, we could close the write side of the stream and reset the read side, and define stream closing as "normal shutdown". The client could then suppress the error when it receives the stream reset (on its write-side of the stream).
3. Or maybe all of this is too complex and we can just live with it?

What do you recommend doing about logging?

We can special-case the deadline error, and either not log anything, or log "ping aborted after 30s" when it occurred.

[vyzo]

want to take it over and mold it to suit your taste?

[MarcoPolo]

I'll carry this forward. 🫡