implement relay v2 discovery #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
discover-v2-relays
branch
from
ff71c8b
to
9c878c3
Compare
marten-seemann
force-pushed
the
discover-v2-relays
branch
from
9c878c3
to
d6fe423
Compare
marten-seemann
force-pushed
the
discover-v2-relays
branch
from
d6fe423
to
90b8076
Compare
marten-seemann
force-pushed
the
discover-v2-relays
branch
from
90b8076
to
7e767cb
Compare
vyzo
reviewed
Apr 5, 2022
p2p/host/autorelay/relay_finder.go
Outdated
| log.Debugw("moving candidate to backoff", "id", cand.ai.ID) | ||
| rf.candidatesOnBackoff = append(rf.candidatesOnBackoff, &candidateOnBackoff{ | ||
| candidate: *cand, | ||
| nextConnAttempt: time.Now().Add(rf.conf.backoff), |
There was a problem hiding this comment.
i think we should do randomized exponential backoff here.
marten-seemann
force-pushed
the
discover-v2-relays
branch
from
1b1eeb0
to
44350ef
Compare
vyzo
approved these changes
Apr 10, 2022
| default: | ||
| // no space left in the channel. Drop the oldest entry. | ||
| <-r.peerChanOut | ||
| r.peerChanOut <- pi |
There was a problem hiding this comment.
isnt this racey with the consumer? I think we should also select here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not yet implement a utility function that would fill the
peerChanwith DHT peers. This will be added in a separate PR.Static Relay selection is a bit shaky when
minCandidatesis smaller than the number of relays, maybe we should just declare that we won't honor theWithMinCandidatesoption when static relays are used.