fix race condition and nil pointer dereference in holepunch #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Are you sure this is what we want? In comment above direct connect we read: So this function should not be accesses by "normal" user |
|
True, but doesn’t cost us anything to lock the mutex there as well, so let’s do it. |
13 tasks
marten-seemann
requested changes
Apr 29, 2022
| @@ -257,5 +266,7 @@ func (s *Service) handleNewStream(str network.Stream) { | |||
| // TODO: find a solution for this. | |||
| func (s *Service) DirectConnect(p peer.ID) error { | |||
| <-s.hasPublicAddrsChan | |||
| s.holePuncherMx.Lock() | |||
| defer s.holePuncherMx.Unlock() | |||
There was a problem hiding this comment.
This locks the mutex for a very long time (on the order of 10s or so). Save s.holePuncher to a local variable instead.
There was a problem hiding this comment.
Or maybe just use RMutex? And call RLock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1448