Update resource manager readme #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagged @BigLep for another approval here. Not expected, but if given I can go ahead and merge this :) |
marten-seemann
requested changes
Aug 17, 2022
| // If memory is smaller than 128 MB, the base configuration will be used. | ||
| func (cfg *ScalingLimitConfig) Scale(memory int64, numFD int) LimitConfig { | ||
| var scaleFactor int |
There was a problem hiding this comment.
Can we move the logic change to a separate PR? Otherwise this will be very confusing if we ever have to go back in the commit history.
BigLep
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Providing approval given libp2p/go-libp2p-resource-manager#78 , but understood there is a request to break out some of the commits.
MarcoPolo
force-pushed
the
marco/update-rcmgr-readme
branch
from
956e52a
to
c8c8f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves https://github.com/libp2p/go-libp2p-resource-manager/pull/78/files to here.