Libp2p examples #185
Libp2p examples #185
Conversation
ghost
mentioned this pull request
hsanjuan
force-pushed
the
libp2p-examples
branch
from
95c4283
to
9c0e31c
Compare
|
Added http-proxy example |
hsanjuan
force-pushed
the
libp2p-examples
branch
2 times, most recently
from
eb9b182
to
15bf00c
Compare
* Do not use testutil to generate random keys and ids since this is a testing dependency. Use crypto.GenerateKeyPair() instead. * Echo full lines * Improve output by telling the user what to run * More code comments License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
force-pushed
the
libp2p-examples
branch
from
15bf00c
to
e9d0fc7
Compare
examples/http-proxy/proxy.go
Outdated
| fmt.Fprintf(os.Stderr, "%s\n", err) | ||
| } | ||
|
|
||
| func die(err error) { |
There was a problem hiding this comment.
Instead of die, we could use log.Fatalln from go's log package
There was a problem hiding this comment.
But I feel bad when I log errors to stdout :(
There was a problem hiding this comment.
the log subpackage logs to stderr though, so you don't have to feel bad!
| req.URL.Host = req.Host | ||
|
|
||
| outreq := new(http.Request) | ||
| *outreq = *req |
There was a problem hiding this comment.
you could just do:
outreq := *req
for the same effect
There was a problem hiding this comment.
Mm yeah fair enough. I copied from https://golang.org/src/net/http/httputil/reverseproxy.go?s=3845:3920#L121 but since we don't pass it around it's ok as you write it.
There was a problem hiding this comment.
nah, need to pass *http.Request to RoundTrip. I'll leave it as it is, in case someone wants to improve it borrowing more stuff from the reverseproxy.go.
| } | ||
|
|
||
| func main() { | ||
| // Choose random ports between 10000-10100 |
There was a problem hiding this comment.
You can also just use port 0
There was a problem hiding this comment.
that's useful but then I have to use more lines to figure out which ephemeral port was picked up...
hsanjuan
force-pushed
the
libp2p-examples
branch
from
e9d0fc7
to
b2a5c6a
Compare
|
@whyrusleeping changed the logging. Thanks! |
|
The tests are unhappy in my other PR, lets see if theyre happy here or not |
The example proxies http requests through a libp2p stream. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
force-pushed
the
libp2p-examples
branch
from
b2a5c6a
to
93802a4
Compare
|
@whyrusleeping heads up, tests are veery happy here :) |
feat: handle no addresses
remove metadata interning
Improved echo example
Added example for multicodecs
Related to ipfs-inactive/docs#17