identify: remove support for Identify Delta #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
identify-remove-delta
branch
2 times, most recently
from
fc47d18
to
f10cd62
Compare
Stebalien
reviewed
Jan 5, 2023
| ids.Host.Peerstore().SetProtocols(p, mes.Protocols...) | ||
| if isPush { | ||
| ids.emitters.evtPeerProtocolsUpdated.Emit(event.EvtPeerProtocolsUpdated{ |
There was a problem hiding this comment.
Hm. We should have been doing this all along...
There was a problem hiding this comment.
Yes. A lot of libp2p users rely on this event, and Push is much more common than Delta.
My Kubo node receives 10x as many Push messages (see Grafana screenshot in #1974). I wonder how many subtle failures were caused by this...
There was a problem hiding this comment.
Turns out we even had an issue for this: #977.
marten-seemann
force-pushed
the
identify-remove-delta
branch
from
2f08a65
to
5093dc1
Compare
marten-seemann
force-pushed
the
identify-remove-delta
branch
from
5093dc1
to
5095f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1974. Fixes #977.
-700 LOC, this is starting to pay off. We'll probably be able to shave off even more later.