consistently use protocol.ID instead of strings

[sukunrt]

This reduces the string to protocol.ID translations happening at various places in the code

Fixes #1886

[marten-seemann]

Can you pull in multiformats/go-multistream#95, so we can see how this will look like in the end?

[sukunrt]

Should I change network.ConnectionState?

[sukunrt]

Can you pull in multiformats/go-multistream#95, so we can see how this will look like in the end?

Do you mean to point the multistream module to the new changes and check? If so, sukunrt/fix-pid-string-conv-ms-merged (https://github.com/sukunrt/go-libp2p/tree/sukunrt/fix-pid-string-conv-ms-merged)
This is the branch with the merged changes.

[marten-seemann]

Can you pull in multiformats/go-multistream#95, so we can see how this will look like in the end?

Do you mean to point the multistream module to the new changes and check? If so, sukunrt/fix-pid-string-conv-ms-merged (https://github.com/sukunrt/go-libp2p/tree/sukunrt/fix-pid-string-conv-ms-merged) This is the branch with the merged changes.

Nice!!!

Should I change network.ConnectionState?

I think it would make sense. What do you think? Does it make the code easier?

[sukunrt]

I think changing network.ConnectionState is correct. That way internally it is always protocol.ID and we only convert to string when dealing with external lib like tls or translating to protobufs.

Updated sukunrt/fix-pid-string-conv-ms-merged with changed network.ConnectionState

[marten-seemann]

@sukunrt I just cut a new release of go-multistream with all your changes: https://github.com/multiformats/go-multistream/tree/v0.4.0.

Can you update this PR to use the release?

[sukunrt]

Updated the branch with all changes merged.

[marten-seemann]

I did a full review, and this looks really good to me. One minor thing, then this should be good to merge. 🎉