rcmgr: Use prometheus SDK for rcmgr metrics #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2054 introduces a global slice pool for all of our metrics code. Should we merge this one first and rebase this PR? I'm also ok with doing this the other way around, or in a follow-up PR. Your call. |
Go ahead and merge that. It's approved. I'll rebase this one. Could you review this one when you get a chance please? |
marten-seemann
approved these changes
Feb 7, 2023
Allows for much more efficient metric collecting
This reverts commit e91b1e8.
MarcoPolo
force-pushed
the
marco/prom-metrics-rcmgr
branch
from
a18ac56
to
4702dc4
Compare
marten-seemann
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1955