Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Example for Issue 205 #206

Closed
wants to merge 1 commit into from
Closed

Conversation

ericxtang
Copy link
Contributor

@ericxtang ericxtang commented Jul 21, 2017

Reference code for #205

Here is the binary for echo, built on my mac.

echo.zip

@ericxtang ericxtang mentioned this pull request Jul 21, 2017
@@ -11,14 +11,18 @@ import (
"log"
mrand "math/rand"

"github.com/golang/glog"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use native go logger in this example, no need for custom one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this was PR is just a demonstration of a bug)

Copy link
Member

@Kubuxu Kubuxu Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. Today I felt like whole day like I was on autopilot so I saw a PR and reviewed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good autopilot habit to have 😄.

@Stebalien
Copy link
Member

This probably doesn't need to stay open.

@Stebalien Stebalien closed this Aug 31, 2017
marten-seemann added a commit that referenced this pull request Apr 22, 2022
update quic-go to v0.21.0-rc2
marten-seemann added a commit that referenced this pull request Aug 15, 2022
@MarcoPolo MarcoPolo mentioned this pull request Jul 14, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants