identify: add some basic metrics #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-shahi
reviewed
Feb 8, 2023
MarcoPolo
approved these changes
Feb 8, 2023
marten-seemann
force-pushed
the
basic-identify-metrics
branch
from
a83940a
to
89efcdb
Compare
marten-seemann
changed the base branch from
refactor-identify-push-sending
to
master
marten-seemann
force-pushed
the
basic-identify-metrics
branch
from
89efcdb
to
83d4df4
Compare
marten-seemann
force-pushed
the
basic-identify-metrics
branch
from
83d4df4
to
92fa579
Compare
MarcoPolo
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're introducing some pretty substantial changes to the Identify protocol. It would be good to have some basic metrics.
We can probably do a lot more here, but this is a beginning so we're not flying completely blind.
Part of #2019.