identify: avoid spuriously triggering pushes #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
identify-spurious-pushes
branch
from
8e765fa
to
f72b82d
Compare
marten-seemann
force-pushed
the
identify-spurious-pushes
branch
from
f72b82d
to
c9c103c
Compare
sukunrt
approved these changes
May 18, 2023
MarcoPolo
pushed a commit
that referenced
this pull request
May 30, 2023
marten-seemann
added a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definitely happens during node startup: We receive a notification for adding the Identify Push protocol, as well as for starting to listen on our addresses. It might also happen later (maybe?).