Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2510: Adding IPv6 cases to transport tests #2531

Conversation

CtrlAltGiri
Copy link

@CtrlAltGiri CtrlAltGiri commented Aug 27, 2023

Fixing #2510

@CtrlAltGiri CtrlAltGiri changed the title Adding IPv6 cases to transport tests #2510: Adding IPv6 cases to transport tests Aug 27, 2023
@marten-seemann
Copy link
Contributor

This will double the run time of this test suite, which is already taking 10s, and we'll be adding more tests in the future. Should this instead be a single IPv6 test?

@MarcoPolo
Copy link
Contributor

Great to see no failures!

I think another 10s is an okay tradeoff because:

  1. We don't really test IPv6 anywhere else.
  2. We really want to test all the things you can do with a transport, this includes doing all those things with IPv6 as well.

Should this instead be a single IPv6 test?

I think if IPv6 had been interoperable with IPv4, this would be something I would agree with. Sadly, we are living in a two stack world, so I think it makes sense to run all these tests with IPv6 as well.

@marten-seemann
Copy link
Contributor

2. We really want to test all the things you can do with a transport, this includes doing all those things with IPv6 as well.

Lots of the tests test functionality that's going on on top of an established connection, for example the stream deadline test, gating test, etc. There's not a lot of value in running those on IPv6, is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants