upgrader: drop support for multistream simultaneous open #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
reviewed
Sep 5, 2023
p2p/net/upgrader/upgrader.go
Outdated
| @@ -201,9 +201,7 @@ func (u *upgrader) upgrade(ctx context.Context, t transport.Transport, maconn ma | |||
|
|
|||
| func (u *upgrader) setupSecurity(ctx context.Context, conn net.Conn, p peer.ID, dir network.Direction) (sec.SecureConn, protocol.ID, bool, error) { | |||
There was a problem hiding this comment.
You don't need the third returned value(bool) right?
AFAICT it is used to indicate whether we are the server which the caller now has complete context of.
There was a problem hiding this comment.
Good catch. This allowed a small refactor to simplify things a tiny bit.
sukunrt
approved these changes
Sep 6, 2023
|
Updated the go-multistream dependency to v0.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2330. For libp2p/specs#573.
Turns out there wasn't even a test for this...
We can also merge multiformats/go-multistream#107 first, cut a new release, and then update go-multistream in this PR.