identify: refactor observed address manager to do address mapping at thin waist(IP+TCP/UDP) layer #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Marco Munizaga <git@marcopolo.io>
MarcoPolo
reviewed
May 15, 2024
MarcoPolo
approved these changes
May 16, 2024
ivan4th
added a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 6, 2024
Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
ivan4th
added a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 6, 2024
Following observed address mechanism breakage in libp2p/go-libp2p#2793 disable automatic libp2p dependency bumps. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
This was referenced Jun 6, 2024
|
This PR broke disconnect handling in |
spacemesh-bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 7, 2024
## Motivation libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too. This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
spacemesh-bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 7, 2024
## Motivation libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too. This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
spacemesh-bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 7, 2024
## Motivation Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an option to disable observed address manager for users who know their external IP addresses.